Skip to content

Fix HtmlToDjot MathML extraction edge cases#166

Merged
dereuromark merged 1 commit intomasterfrom
feature/fix-html-to-djot-math-fallback
Apr 1, 2026
Merged

Fix HtmlToDjot MathML extraction edge cases#166
dereuromark merged 1 commit intomasterfrom
feature/fix-html-to-djot-math-fallback

Conversation

@dereuromark
Copy link
Copy Markdown
Contributor

Summary

  • ignore non-TeX MathML annotation payloads when falling back to plain extracted math text
  • use a safe backtick fence for extracted math content so TeX containing backticks remains valid Djot
  • add converter regressions for both MathML edge cases

Verification

  • vendor/bin/phpunit tests/TestCase/Converter/HtmlToDjotTest.php
  • vendor/bin/phpunit tests/TestCase/Converter/HtmlToDjotTest.php tests/TestCase/RoundTripTest.php tests/TestCase/DjotConverterTest.php
  • vendor/bin/phpstan analyse src --no-progress
  • vendor/bin/phpunit

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.96%. Comparing base (53588fb) to head (73316bf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     93.94%   93.96%   +0.01%     
- Complexity     3106     3113       +7     
============================================
  Files            93       93              
  Lines          7950     7964      +14     
============================================
+ Hits           7469     7483      +14     
  Misses          481      481              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dereuromark dereuromark merged commit 483c934 into master Apr 1, 2026
6 checks passed
@dereuromark dereuromark deleted the feature/fix-html-to-djot-math-fallback branch April 1, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant