Skip to content

Harden generators and fix TS union imports#103

Merged
dereuromark merged 1 commit intomasterfrom
fix/generator-findings
Mar 23, 2026
Merged

Harden generators and fix TS union imports#103
dereuromark merged 1 commit intomasterfrom
fix/generator-findings

Conversation

@dereuromark
Copy link
Contributor

Summary

  • add missing TypeScript imports for DTO references inside union types in multi-file output
  • fail loudly when the TypeScript or JSON Schema generators cannot create output directories or write files
  • add regression tests for both issues and note the generator error behavior in the CLI docs

Verification

  • composer cs-fix
  • vendor/bin/phpunit

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 72.85714% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.70%. Comparing base (fd6239d) to head (f6729f0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Generator/TypeScriptGenerator.php 72.00% 14 Missing ⚠️
src/Generator/JsonSchemaGenerator.php 75.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
+ Coverage     82.46%   82.70%   +0.24%     
- Complexity     1465     1486      +21     
============================================
  Files            42       42              
  Lines          3615     3660      +45     
============================================
+ Hits           2981     3027      +46     
+ Misses          634      633       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereuromark dereuromark merged commit 5b32a8b into master Mar 23, 2026
11 of 12 checks passed
@dereuromark dereuromark deleted the fix/generator-findings branch March 23, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant