Parse union types for circular dependency detection#86
Merged
dereuromark merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
Fixes #85 Union types like `UserDto|AdminDto` are now split and each type is checked for circular dependencies. Added `extractDtoNamesFromType()` method that handles union types by splitting on `|` and extracting DTO names from each part.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
============================================
+ Coverage 83.42% 83.46% +0.03%
- Complexity 1382 1386 +4
============================================
Files 40 40
Lines 3336 3344 +8
============================================
+ Hits 2783 2791 +8
Misses 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractDtoNamesFromType()method that splits union types on|and extracts DTO names from each partUserDto|AdminDtoare now correctly analyzed for circular dependenciesFixes #85
Example
Previously, the union type
ItemADto|ItemBDtowas not parsed, so the circular dependencyContainer -> ItemA -> Containerwas not detected. Now it is correctly detected.