Add intersection type support and fix singularType union parsing#87
Merged
dereuromark merged 1 commit intomasterfrom Mar 23, 2026
Merged
Add intersection type support and fix singularType union parsing#87dereuromark merged 1 commit intomasterfrom
dereuromark merged 1 commit intomasterfrom
Conversation
- Parse singularType field for union types (was only parsing single type)
- Add intersection type (`&`) support to type parsing
- Handle parenthesized DNF types like `(Foo|Bar)&Baz`
- Use `preg_split('/[|&]/')` to split on both operators
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
=========================================
Coverage 83.46% 83.46%
Complexity 1386 1386
=========================================
Files 40 40
Lines 3344 3345 +1
=========================================
+ Hits 2791 2792 +1
Misses 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
singularTypefield to parse union types (was using single-type extraction)&) support to dependency extraction(Foo|Bar)&BazChanges
The
extractDtoNamesFromType()method now:|(union) and&(intersection) operators usingpreg_split('/[|&]/')The
singularTypefield now usesextractDtoNamesFromType()(plural) instead ofextractDtoNameFromType()(singular), ensuring union types in collection singular types are correctly parsed.New Tests
testSingularTypeWithUnionParsedtestIntersectionTypeCircularDependencyDetectedFoo&Barintersection detectedtestLazyIntersectionTypeBreaksCycletestParenthesizedDnfTypeCircularDependencyDetectedtestMixedUnionAndIntersectionTypestestLazySingularTypeUnionBreaksCycle