Fix lazy data handling in serialization, toArray, and validation#90
Merged
dereuromark merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
- Fix _toArrayInternal to check _lazyData before reading property values, ensuring touchedToArray(), __serialize(), and toArray() with parameters correctly preserve unhydrated lazy data - Fix setFromArrayFast template to use array_key_exists() instead of isset() for lazy fields (consistent with method_get.twig fix) - Fix validate() template to check _lazyData for required lazy fields - Add tests for serialization, touchedToArray, and toArray with parameters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=========================================
Coverage 83.47% 83.48%
- Complexity 1386 1388 +2
=========================================
Files 40 40
Lines 3346 3348 +2
=========================================
+ Hits 2793 2795 +2
Misses 553 553 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive fixes for lazy field handling across the codebase.
Serialization & toArray fixes:
_toArrayInternalto check_lazyDatabefore reading property valuestouchedToArray(),__serialize(), andtoArray()with parameters preserve unhydrated lazy dataTemplate fixes:
setFromArrayFastto usearray_key_exists()for lazy fieldssetDefaultstemplate to check_lazyDatafor lazy fields with defaultsvalidate()template to check_lazyDatafor required lazy fieldsmethod_get_or_fail.twigto call getter (handles hydration)method_set_or_fail.twigto clear_lazyDatamethod_with_or_fail.twigto clear_lazyDataBase class fixes:
validate()to check_lazyDatafor required lazy fieldssetDefaults()to not overwrite lazy field dataTests:
Relates to #83