Update code to match the project style guide #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is a result of running phpcbf over the code, and performing some manual changes to ensure that the code passes the phpcs configuration.
As pointed out by Psalm, strtolower only accepts a string, but getAttribute returns mixed. So, in the most simplistic way I know, this change refactors to the code to ensure that the driver name is only passed from getAttribute to strtolower if it is a string.
This change has been made as Psalm can't detect usage of the class on its own, so thinks that it is dead code, when it likely isn't; at least not at the moment.
Pdo's constructor requires three mandatory arguments: a AbstractPdoConnection|PDO object, a StatementInterface&PdoDriverAwareInterface object, and a ResultInterface object. This change mocks the second and third arguments to ensure, which were missing.
I don't see this Psalm failure as an issue for the time being, so am ignoring it in this change, quite visibly so that it will be hard to miss, and attended to in the future.
tyrsson
reviewed
Oct 19, 2025
The change is required to reflect the changes in the package, or to properly reflect the package.
This change is a minor one, changing the code, improving it based on the results of the review.
This is a small change aimed at tightening up the test code. Removing items that are unnecessary, such as checking for the pdo_sqlite extension, and adding in required function arguments, to ensure that the code is as explicit as possible.
Member
|
Why is PHPCS still failing? |
Member
|
composer platform needs updated to 8.2.99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the type of change your PR introduces.
Description:
This change cleans up the code to ensure that it passes all QA tests.