Fixed tests in Unit and Integration#46
Merged
simon-mundy merged 9 commits intophp-db:0.2.xfrom Feb 26, 2026
Merged
Conversation
Signed-off-by: Simon Mundy <simon.mundy@peptolab.com>
simon-mundy
added
BugFix
HouseKeeping
simon-mundy
force-pushed
the
result-count-issue
branch
from
3dff64e to
25c1429
Compare
- Added unit/integration tests for count() - Various minor code cleanups
tyrsson
requested changes
Feb 25, 2026
Member
tyrsson
left a comment
tyrsson
left a comment
There was a problem hiding this comment.
the .laminas-ci phpunit.xml and pre-run.sh are not being added back.
tyrsson
reviewed
Feb 25, 2026
Changed 'stub' to 'mock' Signed-off-by: Simon Mundy <46739456+simon-mundy@users.noreply.github.com>
Signed-off-by: Simon Mundy <46739456+simon-mundy@users.noreply.github.com>
Signed-off-by: Simon Mundy <46739456+simon-mundy@users.noreply.github.com>
Signed-off-by: Simon Mundy <46739456+simon-mundy@users.noreply.github.com>
Member
Author
Reverted |
tyrsson
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This release fixes all the Testing errors introduced since #42 and ensures that (with the correct setup in phpunit.xml) the Integration tests are also able to be run.
The majority of files deal with older/non-existent paths due to the new Namespacing and refactoring. Other changes ensure the correct application of Factories and method signatures.
NOTE: One additional fix is to the Pdo\Driver where changing the $rowCount to null instead of 0 fixes a bug which can affect PhpDb\Result count() methods.
Fixes