The fixed issues were exposed when fixing the incoming issues from th… #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Refactor Sql PR in adapter-mysql. These changes need tested. Signed-off-by: Joey Smith <jsmith@webinertia.net> Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson
added
bug
simon-mundy
requested changes
Dec 9, 2025
Collaborator
simon-mundy
left a comment
simon-mundy
left a comment
There was a problem hiding this comment.
Happy with the changes as-is after the Tests have been updated
Member
Author
|
The test around this should be fixed by the other PR |
Member
Author
|
This PR has been superseded by #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e Refactor Sql PR in adapter-mysql. These changes need tested.
Description
Removes PhpDb\Sql\Ddl\SqlInterface since its simply an extension of PhpDb\Sql\SqlInterface. Splitting that type appears to have zero benefit that I can see.
Fixes several typing issues around the consumption of SqlInterface and PreparableSqlInterface as a PlatformDecoratorInterface implementation.