-
Notifications
You must be signed in to change notification settings - Fork 6
Replace methods, Major type fixes, Phpstan Fixes #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tyrsson
wants to merge
19
commits into
php-db:0.4.x
Choose a base branch
from
tyrsson:replace-removed-featureset-methods-patch
base: 0.4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6526fb7
Replaces callMagicSet, canCallMagicSet that were somehow removed in 0…
tyrsson 7f8c2b8
Replaces missing methods
tyrsson efd31ee
Long list of phpstan changes
tyrsson 218bd26
This finishes resolving all phpstan errors at the current level excep…
tyrsson 25bcc55
Fixes TestAsset\ConnectionWrapper, TestAsset\PdoStubDriver and Connec…
tyrsson 53aedea
Moves AdapterAbstractServiceFactoryTest and AdapterServiceDelegatorTe…
tyrsson 843233c
final currently planned phpunit fixes
tyrsson 5cbc521
Force phpunit to run from the root phpunit.xml.dist config
tyrsson 3e7be50
Pin phpunit to the correct minimum minor for the current configuratio…
tyrsson 5f7272a
Set all test that use reflections setAccesible to be skipped in php 8.5
tyrsson 43ed0f9
Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson b9b2eb0
Refactor to use IgnoreDeprecations attribute along side RequiresPhp t…
tyrsson 91f65aa
Signed-off-by: Joey Smith <jsmith@webinertia.net>
tyrsson 44f4786
Add Attributes for deprecations and required php version to all test …
tyrsson b3663d2
Fix typing for $rowCount in Result
tyrsson 6653e38
Adding .editorconfig for those newbies that might not know how to pro…
tyrsson 247c279
phpcs fixes
tyrsson 0533b82
This commit now includes changes from PR 102 that has been closed.
tyrsson f697b8a
Now includes fix for test triggering notices.
tyrsson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| ; This file is for unifying the coding style for different editors and IDEs. | ||
| ; More information at http://editorconfig.org | ||
|
|
||
| root = true | ||
|
|
||
| [*] | ||
| charset = utf-8 | ||
| indent_size = 4 | ||
| indent_style = space | ||
| end_of_line = lf | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [Makefile] | ||
| indent_style = tab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| /.phpcs-cache | ||
| /.phpunit.result.cache | ||
| /.phpunit.cache | ||
| /.phpstan-cache | ||
| /phpstan.neon | ||
| /phpbench.json | ||
| /clover.xml | ||
| /coveralls-upload.json | ||
| /phpunit.xml | ||
| /vendor/ | ||
| /.vscode |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.