Skip to content

Remove readonly from adapter #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyrsson merged 2 commits into from
Dec 3, 2025
Merged

Remove readonly from adapter #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c93aaa
Remove readonly from adapter
tyrsson Dec 2, 2025
75772c7
Mark abstract factory as internal
tyrsson Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Adapter/Adapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ class Adapter implements AdapterInterface, Profiler\ProfilerAwareInterface, Sche
* @throws Exception\InvalidArgumentException
*/
public function __construct(
protected readonly Driver\DriverInterface $driver,
protected readonly Platform\PlatformInterface $platform,
protected readonly ResultSet\ResultSetInterface $queryResultSetPrototype,
protected Driver\DriverInterface $driver,
protected Platform\PlatformInterface $platform,
protected ResultSet\ResultSetInterface $queryResultSetPrototype = new ResultSet\ResultSet(),
protected ?Profiler\ProfilerInterface $profiler = null
) {
if ($profiler) {
Expand Down
2 changes: 2 additions & 0 deletions src/Container/AdapterAbstractServiceFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
* Database adapter abstract service factory.
*
* Allows configuring several database instances (such as writer and reader).
*
* @internal
*/
class AdapterAbstractServiceFactory implements AbstractFactoryInterface
{
Expand Down
Loading