Fix #224: Segfault while using Ds\Set#225
Merged
rtheunissen merged 1 commit intophp-ds:masterfrom Mar 11, 2026
Merged
Conversation
The string may be refcounted or interned, so freeing is not valid, it should be releasing the string. Also switch to the _func variant as I first believed that we could use the zval_get_tmp_string() function but that would be pointless here as IS_STRING is already handled.
|
Patch seems to work for me when applying to version in Debian Bookworm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The string may be refcounted or interned, so freeing is not valid, it should be releasing the string. Also switch to the _func variant as I first believed that we could use the zval_get_tmp_string() function but that would be pointless here as IS_STRING is already handled.