Skip to content

Conversation

@spekulatius
Copy link
Contributor

No description provided.

@oscarotero
Copy link
Collaborator

phpunit was included as a dev dependency some time ago, but it has been removed in order to use the correct version according with the php version in travis (#82 (comment))

I'm fine including it again (to local testing), but without use a specific version, leaving to composer to choose the best one. For example using "phpunit/phpunit": "*" or "phpunit/phpunit": "4.x|5.x" or something like that.

@spekulatius
Copy link
Contributor Author

Hello @oscarotero

that makes sense. Composer should be able to identify the correct versions.

I have changed it to be *

Cheers,
Spek

@oscarotero
Copy link
Collaborator

Great. Thank you 👍

oscarotero added a commit that referenced this pull request Feb 1, 2016
@oscarotero oscarotero merged commit 43c6b13 into php-embed:master Feb 1, 2016
@spekulatius spekulatius deleted the adding-phpunit-to-dev-requirements branch February 1, 2016 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants