Repeat process only if alternative URL is valid #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L gets valid response.
|
That travis check is failing because of environment variables not being set for a number of PHP versions. |
oscarotero
requested changes
Jun 27, 2017
src/Embed.php
Outdated
| return self::process(Url::create($info->url), $config, $dispatcher); | ||
|
|
||
| //except new result if valid | ||
| if($new_info = self::process(Url::create($info->url), $config, $dispatcher, TRUE)){ |
There was a problem hiding this comment.
Instead this, please use a try/catch. Example:
try {
return self::process(Urll:create($info->url), $config, $dispatcher));
} catch (\Exception $e) {
return $info;
}
|
Great! done that:-) |
oscarotero
requested changes
Jun 27, 2017
src/Embed.php
Outdated
| * @return Adapter | ||
| */ | ||
| private static function process(Url $url, array $config, DispatcherInterface $dispatcher) | ||
| private static function process(Url $url, array $config, DispatcherInterface $dispatcher, $no_exception=FALSE) |
There was a problem hiding this comment.
Thanks. You can now remove this argument and the if below.
|
Yes... of course:-) It's done |
|
thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (e.g. slideshare that is private and allows access with secret link) the alternative URL is invalid. This small change makes Embed return the original $info when the second try fails.