Remove deprecated interpolation in functions.php #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, thanks. |
|
@oscarotero thanks for merging this fix. Any chance of releasing a new tag with this fix now that PHP 8.2 is released? 🙏 |
|
@imliam Yes, sorry. New version 4.4.7 released |
LeSuisse
pushed a commit
to Enalean/tuleap
that referenced
this pull request
Jan 9, 2023
This is part of request #30344: Run Tuleap with PHP 8.2 * Changelog: https://github.com/oscarotero/Embed/blob/v4.4.7/CHANGELOG.md * Issue: php-embed/Embed#506 Change-Id: I6bdd650580327c7d65444d8a3e74982f9ec41126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${var}interpolation will be deprecated in php8.2. With this fix it is replaced with simple interpolation inside double quotes.Link to RFC: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation