Load all JSON-LD data #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LinkedData class was only grabbing the first application/ld+json script tag found in the DOM. It now finds them all and makes them all available via the getAll method. Additionally, it inspects the mainEntityOfPage property of the json nodes and if a match is found with the request URI, that node is assigned as the default node rather than the first node found.
Collaborator
|
Thanks! |
Contributor
Author
|
I will have a look at 8.1, thanks. |
Contributor
Author
|
Yep, the default flags for html_entity_decode changed in PHP 8.1 |
Contributor
Author
|
Tested on 8.0 and 8.1. I don't have 7.4 anywhere around to test with though. Hopefully it passes OK as well with this change. |
Collaborator
|
thanks! the tests keep failing but it's due a different issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LinkedData class was only grabbing the first application/ld+json
script tag found in the DOM. It now finds them all and makes them
all available via the getAll method. Additionally, it inspects the
mainEntityOfPage property of the json nodes and if a match is found
with the request URI, that node is assigned as the default node
rather than the first node found.