Fix more attributes and nullables

Author: andrewmy

pkg/amqp-bunny/Tests/AmqpConnectionFactoryTest.php

@@ -5,12 +5,14 @@
 use Enqueue\AmqpBunny\AmqpConnectionFactory;
 use Enqueue\AmqpTools\RabbitMqDlxDelayStrategy;
 use Enqueue\Test\ClassExtensionTrait;
+use Enqueue\Test\ReadAttributeTrait;
 use Interop\Queue\ConnectionFactory;
 use PHPUnit\Framework\TestCase;
 
 class AmqpConnectionFactoryTest extends TestCase
 {
     use ClassExtensionTrait;
+    use ReadAttributeTrait;
 
     public function testShouldImplementConnectionFactoryInterface()
     {

pkg/amqp-lib/Tests/AmqpConnectionFactoryTest.php

@@ -5,12 +5,14 @@
 use Enqueue\AmqpLib\AmqpConnectionFactory;
 use Enqueue\AmqpTools\RabbitMqDlxDelayStrategy;
 use Enqueue\Test\ClassExtensionTrait;
+use Enqueue\Test\ReadAttributeTrait;
 use Interop\Queue\ConnectionFactory;
 use PHPUnit\Framework\TestCase;
 
 class AmqpConnectionFactoryTest extends TestCase
 {
     use ClassExtensionTrait;
+    use ReadAttributeTrait;
 
     public function testShouldImplementConnectionFactoryInterface()
     {

pkg/dbal/Tests/DbalConnectionFactoryTest.php

@@ -28,7 +28,7 @@ public function testShouldCreateLazyContext()
         $this->assertInstanceOf(DbalContext::class, $context);
 
         $this->assertAttributeEquals(null, 'connection', $context);
-        $this->assertAttributeInternalType('callable', 'connectionFactory', $context);
+        $this->assertIsCallable($this->readAttribute($context, 'connectionFactory'));
     }
 
     public function testShouldParseGenericDSN()

pkg/dbal/Tests/ManagerRegistryConnectionFactoryTest.php

@@ -73,7 +73,7 @@ public function testShouldCreateLazyContext()
         $this->assertInstanceOf(DbalContext::class, $context);
 
         $this->assertAttributeEquals(null, 'connection', $context);
-        $this->assertAttributeInternalType('callable', 'connectionFactory', $context);
+        $this->assertIsCallable($this->readAttribute($context, 'connectionFactory'));
     }
 
     /**

pkg/enqueue/Tests/Consumption/QueueConsumerTest.php

@@ -1537,6 +1537,9 @@ private function createExtension()
      */
     private function createConsumerStub($queue = null): Consumer
     {
+        if ($queue === null) {
+            $queue = 'queue';
+        }
         if (is_string($queue)) {
             $queue = new NullQueue($queue);
         }

pkg/enqueue/Tests/Symfony/Client/ConsumeCommandTest.php

@@ -677,6 +677,9 @@ private function createExtension()
      */
     private function createConsumerStub($queue = null): Consumer
     {
+        if ($queue === null) {
+            $queue = 'queue';
+        }
         if (is_string($queue)) {
             $queue = new NullQueue($queue);
         }

pkg/enqueue/Tests/Symfony/Consumption/ConsumeCommandTest.php

@@ -221,6 +221,9 @@ private function createExtension()
      */
     private function createConsumerStub($queue = null): Consumer
     {
+        if ($queue === null) {
+            $queue = 'queue';
+        }
         if (is_string($queue)) {
             $queue = new NullQueue($queue);
         }

pkg/fs/Tests/LegacyFilesystemLockTest.php

@@ -6,12 +6,14 @@
 use Enqueue\Fs\LegacyFilesystemLock;
 use Enqueue\Fs\Lock;
 use Enqueue\Test\ClassExtensionTrait;
+use Enqueue\Test\ReadAttributeTrait;
 use Makasim\File\TempFile;
 use PHPUnit\Framework\TestCase;
 
 class LegacyFilesystemLockTest extends TestCase
 {
     use ClassExtensionTrait;
+    use ReadAttributeTrait;
 
     public function testShouldImplementLockInterface()
     {

pkg/redis/Tests/RedisProducerTest.php

@@ -67,7 +67,7 @@ public function testShouldCallLPushOnSend()
                 $this->assertNotEmpty($message['headers']['message_id']);
                 $this->assertSame(0, $message['headers']['attempts']);
 
-                return true;
+                return 1;
             })
         ;
 

pkg/stomp/Tests/StompConsumerTest.php

@@ -523,8 +523,8 @@ public function testShouldGenerateUniqueSubscriptionIdPerConsumer()
         $fooConsumer = new StompConsumer($this->createStompClientMock(), $destination);
         $barConsumer = new StompConsumer($this->createStompClientMock(), $destination);
 
-        $this->assertAttributeNotEmpty('subscriptionId', $fooConsumer);
-        $this->assertAttributeNotEmpty('subscriptionId', $barConsumer);
+        $this->assertNotEmpty($this->readAttribute($fooConsumer, 'subscriptionId'));
+        $this->assertNotEmpty($this->readAttribute($barConsumer, 'subscriptionId'));
 
         $fooSubscriptionId = $this->readAttribute($fooConsumer, 'subscriptionId');
         $barSubscriptionId = $this->readAttribute($barConsumer, 'subscriptionId');