Skip to content

[Bug]: prevent label-sync failures when no issue is linked (#157)#158

Merged
coisa merged 4 commits intomainfrom
bugfix/157-label-sync-no-linked-issue
Apr 22, 2026
Merged

[Bug]: prevent label-sync failures when no issue is linked (#157)#158
coisa merged 4 commits intomainfrom
bugfix/157-label-sync-no-linked-issue

Conversation

@coisa
Copy link
Copy Markdown
Contributor

@coisa coisa commented Apr 22, 2026

Summary

  • stop label-sync from failing when a PR does not reference any linked issue
  • keep the no-linked-issue path as an explicit no-op with a friendly log message
  • record the fix in CHANGELOG.md

Root Cause

The action parsed linked issue references with a grep pipeline inside command substitution while running under set -euo pipefail. When no match existed, grep exited with status 1 before the script reached the fallback branch that should have exited successfully.

Verification

  • reproduced the no-linked-issue case locally with a synthetic GITHUB_EVENT_PATH
  • verified the script now prints No linked issue was found... and exits 0
  • verified the linked-issue path still reaches the later no-labels handling path
  • COMPOSER_NO_INTERACTION=1 composer dev-tools:fix

Closes #157

@coisa coisa force-pushed the bugfix/157-label-sync-no-linked-issue branch from 5913a91 to 47da145 Compare April 22, 2026 03:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 22, 2026

@coisa coisa merged commit 7a5664a into main Apr 22, 2026
27 of 29 checks passed
@coisa coisa deleted the bugfix/157-label-sync-no-linked-issue branch April 22, 2026 03:26
@github-project-automation github-project-automation Bot moved this from Backlog to Released in PHP Fast Forward Project Apr 22, 2026
github-actions Bot added a commit that referenced this pull request Apr 22, 2026
coisa added a commit that referenced this pull request Apr 22, 2026
* Revert "[Bug]: prevent label-sync failures when no issue is linked (#157) (#158)"

This reverts commit 7a5664a.

* [label-sync] Parse linked issues safely with jq (#157)

* Update wiki submodule pointer for PR #159

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

[Bug]: label-sync should not fail when a PR has no linked issue

1 participant