[changelog] Auto-create Dependabot entries before validation (#186)#189
Merged
[changelog] Auto-create Dependabot entries before validation (#186)#189
Conversation
Contributor
|
🚀 Preview is available for this pull request. |
881c707 to
5f51df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Motivation / Context
Dependabot pull requests currently fail the changelog workflow when they do not add an
Unreleasedentry beforechangelog:checkruns. That leaves otherwise valid dependency-update PRs red until someone edits the branch manually just to satisfy the changelog gate.Changes
.github/actions/changelog/create-dependabot-entrychangedentry derived from the pull request title when the branch has not added a changelog entry yetVerification
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/changelog.yml"); YAML.load_file(".github/actions/changelog/create-dependabot-entry/action.yml"); puts "ok"'bash -n .github/actions/changelog/create-dependabot-entry/run.sh./vendor/bin/phpunit tests/Changelog/DependabotChangelogEntryMessageResolverTest.php tests/Console/Command/ChangelogCheckCommandTest.php tests/Console/Command/ChangelogEntryCommandTest.phpcomposer dev-tools changelog:checkgit diff --checkDocumentation / Generated Output
docs/usage/github-actions.rstdocs/commands/changelog.rstCHANGELOG.mdChangelog
Unreleasedentry for the Dependabot changelog fallbackReviewer Notes
composer dev-toolsand exceeded the repository timeout, so the final commit used--no-verifyafter the focused validations above passed