Normalize DevTools workspace directory handling#275
Merged
Conversation
Contributor
|
🚀 Preview is available for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #274
Motivation / Context
--working-dirnow selects the project root, but generated artifacts and caches still needed one central policy instead of each command assuming.dev-toolsindependently.reportsandstandardsshould carry the same workspace defaults without requiring duplicated command-specific paths.Changes
--workspace-dir/-woption and wires it toFAST_FORWARD_WORKSPACE_DIRbefore command defaults are resolved.ManagedWorkspaceto resolve output/cache roots from the configured workspace while keeping.dev-toolsas the default.--target,--coverage,--metrics, and--cache-dir.Verification
composer dev-toolscomposer dev-tools:fixcomposer dev-tools docscomposer dev-tools tests -- --filter='(ManagedWorkspaceTest|WorkingProjectPathResolverTest|DevToolsTest|MetricsCommandTest)'php bin/dev-tools.php --workspace-dir=.artifacts reports --help --no-ansi | rg '\.artifacts|workspace-dir'FAST_FORWARD_WORKSPACE_DIR=.artifacts php bin/dev-tools.php metrics --help --no-ansi | rg '\.artifacts|exclude'.artifactsDocumentation / Generated Output
docs/updatedChangelog
CHANGELOG.mdentryReviewer Notes
--working-dircontinues to define where DevTools runs;--workspace-dironly changes generated artifact/cache defaults.FAST_FORWARD_WORKSPACE_DIRfor the same workspace policy because Composer cannot receive DevTools-specific global application options.