[command] Add global dev-tools no-logo control for nested runs#278
Merged
[command] Add global dev-tools no-logo control for nested runs#278
Conversation
Signed-off-by: Felipe Sayão Lobato Abreu <github@mentordosnerds.com>
Contributor
|
🚀 Preview is available for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show banner at startup for top-level DevTools runs and suppress it for orchestrated child runs.
Changes
--no-logoglobal option insrc/Console/DevTools.php.doRun()only when--no-logois not passed.--no-logoautomatically for nested DevTools subprocesses insrc/Process/ProcessBuilder.php.tests/Console/DevToolsTest.phpandtests/Process/ProcessBuilderTest.php.Testing
vendor/bin/phpunit tests/Console/DevToolsTest.php tests/Process/ProcessBuilderTest.phpcomposer dev-tools(not available in this environment: composer: command not found)Closes #277