Skip to content

[path] Complete runtime-aware binary fallbacks for remaining commands (#297)#298

Merged
coisa merged 5 commits intomainfrom
bugfix/297-runtime-tool-binaries
Apr 30, 2026
Merged

[path] Complete runtime-aware binary fallbacks for remaining commands (#297)#298
coisa merged 5 commits intomainfrom
bugfix/297-runtime-tool-binaries

Conversation

@coisa
Copy link
Copy Markdown
Contributor

@coisa coisa commented Apr 30, 2026

Related Issue

Closes #297

Motivation / Context

  • Global fast-forward/dev-tools installs still failed in the remaining command flows that hardcoded vendor/bin/phpdoc, vendor/bin/phpunit, or vendor/bin/phpmetrics.
  • Consumer repositories that do not install those binaries locally should still be able to use the active DevTools runtime fallback.

Changes

  • Route DocsCommand, WikiCommand, TestsCommand, and MetricsCommand through DevToolsPathResolver::getPreferredToolBinaryPath(...).
  • Keep process command arrays explicit so runtime binary paths are not split on spaces.
  • Extend command and path resolver coverage for the remaining phpdoc, phpunit, and phpmetrics flows.
  • Add a CHANGELOG.md entry for the automation-facing fix.

Verification

  • composer dev-tools
  • Focused command(s): composer dev-tools tests -- --filter='(DocsCommandTest|WikiCommandTest|MetricsCommandTest|TestsCommandTest|DevToolsPathResolverTest)'
  • Manual verification: not run separately; covered by the command and resolver test coverage added here.

Documentation / Generated Output

  • README updated
  • docs/ updated
  • Generated or synchronized output reviewed

Changelog

  • Added a notable CHANGELOG.md entry

Reviewer Notes

  • This completes the runtime-aware binary fallback follow-up from #292 for the remaining phpDocumentor, PHPUnit, and PhpMetrics command paths.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8df8d6a85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Console/Command/WikiCommand.php
@coisa coisa merged commit 4b6dd63 into main Apr 30, 2026
12 checks passed
@coisa coisa deleted the bugfix/297-runtime-tool-binaries branch April 30, 2026 03:10
@github-project-automation github-project-automation Bot moved this from Backlog to Released in PHP Fast Forward Project Apr 30, 2026
github-actions Bot added a commit that referenced this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

Apply runtime-aware binary resolution to remaining phpDocumentor, PHPUnit, and PhpMetrics commands

1 participant