Skip to content

[wiki] Push publish branch explicitly (#48)#51

Merged
coisa merged 2 commits intomainfrom
codex/48-wiki-explicit-publish-push
Apr 17, 2026
Merged

[wiki] Push publish branch explicitly (#48)#51
coisa merged 2 commits intomainfrom
codex/48-wiki-explicit-publish-push

Conversation

@coisa
Copy link
Copy Markdown
Contributor

@coisa coisa commented Apr 17, 2026

Summary

Fixes the publish step uncovered after PR #50. The publish job reset the local wiki branch to the PR preview commit, but EndBug/add-and-commit skipped pushing because the working tree was clean. This changes the publish step to push the selected wiki commit explicitly before deleting the preview branch.

Changes

  • Replaces the publish EndBug/add-and-commit step with git push --force-with-lease origin HEAD:${WIKI_PUBLISH_BRANCH}.
  • Keeps preview branch deletion after the publish push, so failed publish attempts preserve the PR wiki branch for investigation.

Testing

  • git diff --check passed.
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/wiki.yml"); puts "YAML OK"' passed.
  • Commit hooks passed: GrumPHP composer_script, composer, phplint, jsonlint, and yamllint.
  • Verified from the previous publish log that EndBug/add-and-commit reported pushed: false when the working tree was clean.

Closes #48

@github-actions github-actions Bot added the bug Something isn't working label Apr 17, 2026
@coisa coisa merged commit 3fd9aa1 into main Apr 17, 2026
2 checks passed
@coisa coisa deleted the codex/48-wiki-explicit-publish-push branch April 17, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Released

Development

Successfully merging this pull request may close these issues.

Fix wiki workflow branch-protection publishing flow

1 participant