fix: Update default operating systems to use 'windows-2022' across workflows and documentation. #53
Conversation
…rkflows and documentation.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
WalkthroughAdds an optional hook input and step to reusable workflows, replaces deprecated before-hook in phpunit workflow, and updates Windows runner defaults from windows-latest to windows-2022 across workflows and README. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller as Workflow Caller
participant Reusable as Reusable Workflow (phpunit/codeception)
participant Runner as GitHub Runner
participant Tests as Test Jobs (Matrix)
Caller->>Reusable: workflow_call (inputs: os[], hook?)
Reusable->>Runner: Setup job
alt hook provided
Runner->>Runner: Run hook (bash -c "<hook>")
else no hook
Note over Runner: Skip hook
end
Runner->>Runner: Generate base-class (if applicable)
par Matrix
Runner->>Tests: ubuntu-latest job
Runner->>Tests: windows-2022 job
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/codeception.yml (2)
41-45: New hook input is useful; clarify execution context.Consider stating in the description that the hook runs in bash on all OSes to avoid confusion on Windows runners.
hook: - description: Hook to run. + description: Hook to run (executed with bash on all OS runners; supports multi-line).
111-115: Harden the hook step and support multi-line commands.Prepend strict bash flags to fail fast and handle multi-line hooks more reliably.
- name: Run hook. if: inputs.hook != '' - run: ${{ inputs.hook }} + run: | + set -euo pipefail + ${{ inputs.hook }} shell: bash.github/workflows/phpunit.yml (2)
46-50: New hook input: good addition; minor doc tweak suggested.hook: - description: Hook to run. + description: Hook to run (executed with bash on all OS runners; supports multi-line).
142-146: Apply stricter bash flags for the hook step.Same rationale as in codeception: fail fast and handle multi-line hooks.
- name: Run hook. if: inputs.hook != '' - run: ${{ inputs.hook }} + run: | + set -euo pipefail + ${{ inputs.hook }} shell: bash
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.github/workflows/codeception.yml(2 hunks).github/workflows/phpunit-database.yml(1 hunks).github/workflows/phpunit.yml(2 hunks)README.md(1 hunks)
🔇 Additional comments (4)
README.md (1)
182-182: Approve update; no windows-latest references remaining
Verified removal of allwindows-latestoccurrences in code and docs..github/workflows/phpunit-database.yml (1)
84-84: Approved: OS matrix updated to “windows-2022” with no remaining references to “windows-latest.”.github/workflows/codeception.yml (1)
48-48: OS default switch to windows-2022: approved..github/workflows/phpunit.yml (1)
53-53: Approved: default OS now includes windows-2022.
Summary by CodeRabbit
New Features
Chores
Documentation