Skip to content

Conversation

@sagikazarmark
Copy link
Member

@joelwurtz I changed Socket client docs as well.

@sagikazarmark
Copy link
Member Author

@ddeboer can you help me with the failing tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diactoros and Guzzle

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean remove PSR-7?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace "are" by "and" :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch.

@sagikazarmark
Copy link
Member Author

@joelwurtz @dbu good catch, thanks. Now I have another problem related to ref 😞

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you define a label discovery somewhere? if you want to link to the document discovery.rst, its :doc:. :ref: is for linking to labels within some page (anchor links in the same or another page).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I thought I can just link to a page with the same name 😄

Fix indentation

Fix cross-linking

Fix cross-linking

Fix cross-linking
sagikazarmark added a commit that referenced this pull request Feb 1, 2016
Add Guzzle 5 documentation
@sagikazarmark sagikazarmark merged commit 92021ee into master Feb 1, 2016
@sagikazarmark sagikazarmark deleted the guzzle5 branch February 1, 2016 09:14
shulard pushed a commit to shulard/documentation that referenced this pull request Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants