-
-
Notifications
You must be signed in to change notification settings - Fork 3
add support for Gitlab #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hm.. I struggle to download the final release... It seams to be a known gitlab issue |
|
Could you share a public GitLab repository with binaries in mind where I can test the feature? |
I only have private ones. But I can create one for us to try it out. |
|
Here you go: A nice little project with a readme and a .gitlab-ci.yml file. |
|
In my case, it gets an empty list of assets. It picks up releases well. Config: <?xml version="1.0"?>
<dload
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="dload.xsd"
temp-dir="./runtime"
>
<actions>
<download software="cool" version="1.1.0" />
</actions>
<registry overwrite="true">
<software name="cool" description="Cool binaries" homepage="https://gitlab.com/Nyholm/dload-demo">
<repository type="gitlab" uri="Nyholm/dload-demo" />
<binary name="cool" pattern="/.*/" />
</software>
</registry>
</dload>Output: > bin/dload software
There are 1 software available:
cool cool
Homepage: https://gitlab.com/Nyholm/dload-demo
gitlab: Nyholm/dload-demo
Cool binaries
> bin/dload get cool -vv
Architecture: X86_64
Op. system: Windows
Stability: Stable
Trying to load from repo `Nyholm/dload-demo`
Loading releases from `gitlab` repository Nyholm/dload-demo
1 releases found.
Loading release `1.1.0`
0 matching assets found.
No relevant assets found.
... |
|
Ah, got it. I'm on Windows, and there are no assets for Windows 🙂 |
|
Claude about Prefer
|
|
Please let me know if you plan to add anything here, or if I can merge and make a new release. |
|
Thank you for the review.
I played around with both. The majority of time was spend on working around a series of Gitlab bugs. There is no way to download private gitlab release assets, you have to do the workaround with adding package (which is done automatically when using the gitlab cli). When I finally got it to work I was just happy and did not test which URL was best. I tested now and both works.
Yes, you are right. Sorry.
Im happy and done. I've tested it around with my fork all day today. It works great. |
|
The feature is available in 1.8.0 |
|
Wohoo. Thank you |
What was changed
I copied and modified the Github support to make sure I can use the Gitlab API to download my private resources
Why?
I love the fact that I can download binaries and someone else take care of figuring out what architecture.
Checklist