defineFunctionMock() should be static so that it can be used with @beforeClass

Author: malkusch

classes/PHPMock.php

@@ -116,7 +116,7 @@ public function registerForTearDown(Deactivatable $deactivatable)
      * is doing this for you. But if the mock is defined after the first call in the
      * tested class, the tested class doesn't resolve to the mock. This is
      * documented in Bug #68541. You therefore have to define the namespaced
-     * function before the first call (e.g. with @beforeClass).
+     * function before the first call (e.g. with the beforeClass annotation).
      *
      * Defining the function has no side effects. If the function was
      * already defined this method does nothing.
@@ -127,7 +127,7 @@ public function registerForTearDown(Deactivatable $deactivatable)
      * @param string $namespace The function namespace.
      * @param string $name      The function name.
      */
-    public function defineFunctionMock($namespace, $name)
+    public static function defineFunctionMock($namespace, $name)
     {
         $functionMockBuilder = new MockBuilder();
         $functionMockBuilder->setNamespace($namespace)

tests/PHPMockTest.php

@@ -34,7 +34,7 @@ protected function disableMocks()
      */
     public function testDefineFunctionMock()
     {
-        $this->defineFunctionMock(__NAMESPACE__, "escapeshellcmd");
+        self::defineFunctionMock(__NAMESPACE__, "escapeshellcmd");
         self::escapeshellcmd("foo");
 
         $mock = $this->getFunctionMock(__NAMESPACE__, "escapeshellcmd");