Don’t close the cURL handle more than once #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When close() was called more than once PHP warnings appeared stating that "XY is not a valid cURL handle resource". This was especially problematic when close() was called manually because it will also *always* be called from the destructor. From no on we’ll first check whether $this->curl is still a resource to avoid that.
Contributor
Author
|
BTW: The Travis CI build already failed before due to the same error (see https://travis-ci.org/php-mod/curl/builds/31105922), so that’s not my fault. |
amouhzi
added a commit
that referenced
this pull request
Aug 14, 2014
Don’t close the cURL handle more than once
Member
|
Thank you for the pull request, I know for the failure. A new version (1.1.5) for this merge is released. |
Contributor
Author
|
Wow, merged after 11 minutes, that was fast! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When close() was called more than once PHP warnings appeared stating that "XY is not a valid cURL handle resource". This was especially problematic when close() was called manually because it will also always be called from the destructor. From no on we’ll first check whether $this->curl is still a resource to avoid that.
Besides that: great Job!