Skip to content

PSR2 compliance #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2015
Merged

PSR2 compliance #8

merged 1 commit into from
Jan 10, 2015

Conversation

@charlycoste
Copy link
Contributor

@charlycoste charlycoste commented Jan 9, 2015

Complying to PSR2 conventions

Just in case...

amouhzi added a commit that referenced this pull request Jan 10, 2015
@amouhzi
Merge pull request #8 from charlycoste/PSR2
533fa48 
PSR2 compliance
@amouhzi amouhzi merged commit 533fa48 into php-mod:master Jan 10, 2015
@amouhzi
Copy link
Member

amouhzi commented Jan 10, 2015

Thank you for your contribution. I like me too to follow conventions.

@charlycoste charlycoste deleted the PSR2 branch January 10, 2015 02:51
@charlycoste
Copy link
Contributor Author

charlycoste commented Jan 10, 2015

You're welcome ;)

@charlycoste
Copy link
Contributor Author

charlycoste commented Jan 10, 2015

Sorry, but I realized that by adding

script:
- ./vendor/bin/phpcs --warning-severity=0 --standard=PSR2 src

to your .travis.yml file, I overrided the default phpunit run

So you would propably prefer to add :

script:
- ./vendor/bin/phpcs --warning-severity=0 --standard=PSR2 src
- phpunit

@amouhzi
Copy link
Member

amouhzi commented Jan 10, 2015

Many thanks, I didn't noticed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charlycoste @amouhzi