Skip to content

Server groups#435

Merged
k0ka merged 6 commits intomasterfrom
server_groups
Mar 7, 2026
Merged

Server groups#435
k0ka merged 6 commits intomasterfrom
server_groups

Conversation

@k0ka
Copy link
Member

@k0ka k0ka commented Mar 7, 2026

fixes #434

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Compute v2 “Server Groups” support to the SDK, addressing issue #434 by introducing a ServerGroup model plus the corresponding API/service surface, tests, samples, and docs.

Changes:

  • Added ServerGroup model with list/retrieve/create/delete support and response-shape compatibility for policy vs policies.
  • Exposed server-group operations in Compute\v2\Api + Compute\v2\Service, including query params like all_projects, limit, and offset.
  • Added unit tests, sample tests, runnable samples, and Sphinx docs for server groups.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Compute/v2/Api.php Adds REST operation definitions for server-group CRUD/list.
src/Compute/v2/Models/ServerGroup.php Implements the ServerGroup resource behavior and hydration rules.
src/Compute/v2/Params.php Adds parameter schemas for server-group list/create options (incl. rules).
src/Compute/v2/Service.php Adds top-level service methods: list/create/get server groups.
tests/unit/Compute/v2/ServiceTest.php Adds service-level tests for server-group create/list/get.
tests/unit/Compute/v2/Models/ServerGroupTest.php Adds model-level tests for server-group retrieve/create/delete and option validation.
tests/unit/Compute/v2/Fixtures/*.resp Adds mocked HTTP fixtures for server-group list/get/post.
samples/Compute/v2/server_groups/*.php Adds user-facing sample scripts for server-group workflows.
tests/sample/Compute/v2/ServerGroupTest.php Adds integration-style sample test coverage for server groups.
doc/services/compute/v2/server-groups.rst Adds end-user documentation for server groups, including microversion guidance.
doc/services/compute/v2/index.rst Links the new server-groups doc page into the Compute v2 docs index.
AGENTS.md Documents repository architecture, conventions, and compatibility/testing expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@k0ka k0ka merged commit 22c3c9a into master Mar 7, 2026
28 checks passed
@k0ka k0ka deleted the server_groups branch March 7, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server Group API

2 participants