vClock annoyances

[bachpedersen]

Creating input classes and moving the vClock around gets really annoying.
We should figure out a smarter way at some point.

[bachpedersen]

@FabioBatSilva is it ok if I change it a bit, so that it will always take vclock from the object, unless the vclock has been set on input?.
The input will still take precedence but only if the vclock has been set on it.

[FabioBatSilva]

@TriKaspar Sure.. It make sense..

[guilhermeblanco]

That's what I asked @FabioBatSilva , no?

$object = $input->getObject();
$vClock = $object->getVClock();

if ( ! $vClock) {
    $vClock = $input->getVClock();
}

[FabioBatSilva]

@guilhermeblanco, the current implementation is :

function put($object, $input = null){
    if ($input) {
        $vClock = $input->getVClock();
    } else {
        $vClock = $object->getVClock();
    }

   // ....
}

if I got it correctly @TriKaspar's suggestion is to change it to something like :

function put($object, $input = null){

    $vClock = $object->getVClock();

    if ($input && $input->getVClock() {
        $vClock = $input->getVClock();
    }

   // ....
}

[bachpedersen]

Yes the solution @FabioBatSilva have written last because:

• It wont break existing code
• You have to explicitly set the vclock on the input, this means the user decided which vclock should be used.
  If object->vclock where to take precedence, it would mean you would have to clear the object vclock (as it get set automatically) to force the vclock from input to be used, this could only make sence if we wanted to kill the input->vclock.