Skip to content

Conversation

@thecaliskan
Copy link
Contributor

No description provided.

@thecaliskan
Copy link
Contributor Author

Hi @Nyholm

I hope you are doing well. When you have a moment, Could you check PR?

@shulard
Copy link

shulard commented Nov 10, 2025

Hello !

I saw your PR thank you for the proposal (I'm trying to install Symfony 8 and it might help), maybe you can rebase all the commits to have a single one (today there are 18, most of them have an unrelevant description).

Or maybe split the different kind of changes in different commits…

This will help the review I guess.

@thecaliskan
Copy link
Contributor Author

@thecaliskan
Copy link
Contributor Author

Hi @shulard

Rebased. Thanks

@thecaliskan
Copy link
Contributor Author

Hi @Nyholm, I hope you're well .

If you have available time, Could you review this PR ?

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just one minor.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit ff3cfe4 into php-runtime:main Dec 2, 2025
285 of 286 checks passed
@thecaliskan
Copy link
Contributor Author

@Nyholm

Could you release the new versions, especially for Swoole?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants