Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Conversation

@azjezz
Copy link
Collaborator

@azjezz azjezz commented Nov 30, 2022

closes #143

  • add prelude
  • moved ast to parser
  • moved Lexer from crate::lexer::lexer::Lexer to crate::lexer::Lexer
  • renamed LexerError to SyntaxError
  • moved SyntaxError to token::error
  • implemented Display for SyntaxError
  • add tokens.txt to integration tests
  • removed all unit tests for Lexer ( everything is tested in integration tests )
  • improved syntax error assertations

Copy link
Contributor

@ryangjchandler ryangjchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny spelling mistake - otherwise perfect. Thanks for removing that lexer config crap, been meaning to get rid of it.

@azjezz azjezz force-pushed the prelude branch 2 times, most recently from fcf9356 to 8df879e Compare November 30, 2022 23:53
@azjezz
Copy link
Collaborator Author

azjezz commented Nov 30, 2022

i believe that ast should be moved within parser, it doesn't make sense to have ast in root, while token is in lexer.

@azjezz azjezz force-pushed the prelude branch 6 times, most recently from 5bee9ed to a5f8e41 Compare December 1, 2022 00:27
Signed-off-by: azjezz <azjezz@protonmail.com>
@azjezz azjezz closed this Dec 1, 2022
@azjezz azjezz mentioned this pull request Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce a prelude

2 participants