BC BREAK: Preserve order of insertions and transformers #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AydinHassan
force-pushed
the
preserve-order-of-code-patches
branch
from
5620a2e to
2af099d
Compare
Current coverage is 88.66%@@ master #115 diff @@
==========================================
Files 69 69
Lines 1574 1578 +4
Methods 280 280
Messages 0 0
Branches 0 0
==========================================
+ Hits 1395 1399 +4
Misses 179 179
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a BC break but it's weird behaviour.
If you add a transformer that wraps code in a
try/catchthen add a insertion which add a line of code at the top of the file, the inserted code would actually be placed inside thetry/catch.Since we are on 0.* releases we can break BC in
0.5.There's a few things I wanna fix so i'll leave this open until the others collect up.