New XML elements added to output

[sakarikl]

https://github.com/php-sepa-xml/php-sepa-xml/blame/master/src/DomBuilder/CustomerCreditTransferDomBuilder.php#L165

Following xml output added

       <PmtTpInf>
          <SvcLvl>
            <Cd>SEPA</Cd>
          </SvcLvl>
        </PmtTpInf>

inside CdtTrfTxInf element which did not previously have it (using pain format: pain.001.001.03 )

Should this happen?

[BorislavSabev]

@sakarikl yes this was done to unify the implementations for SCT and SDD. The Service Level has been in the SDD generator since the beginning.
This is valid for pain.001.001.03 as per the MDR from iso20022.org and the produced files validate against the XDSs for all supported versions.

Are you having any issues with it?

[sakarikl]

No I was just wondering since our tests needed to be updated.

Thanks for the information.

[BorislavSabev]

@sakarikl we already test against all generated files against all XSDs and we have UNIT tests for >=90% of the internal library method.

Just out of curiosity - what kind of additional tests are you running against the generated files?

[sakarikl]

@BorislavSabev We test the whole xml files generated against previously generated ones.