Widen callable type to allow empty string default value #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Widens the callable-typed parameters to also allow the default value
''. Related: #289.Affected:
Custom_Background::__construct()Custom_Image_Header::__construct()Also makes the callable type explicit by adding parameter and return types. These callables are either hooked to
admin_head-{$page}, which does not pass any arguments, or passed tocall_user_func()without arguments. As an action hook,admin_head-{$page}expects a callable with avoidreturn type.call_user_func()is used in a template context where side effects are expected, but no return value is used. Hence,callable(): void.