Skip to content

Conversation

@rjkip
Copy link
Contributor

@rjkip rjkip commented Mar 9, 2016

I'd like to use this library in a Symfony 3, PHP 7 project. This changeset allows Symfony 3 components to be installed, tests Symfony 2.4/2.6 through 3.0 and requires that the tests pass for PHP 7.

@wtfzdotnet
Copy link
Member

@rjkip I'll get back to you on this one tonight 👍

wtfzdotnet added a commit that referenced this pull request Mar 9, 2016
Test support for Symfony 2.4/2.6 through 3.0 and require support of PHP 7
@wtfzdotnet wtfzdotnet merged commit ebb6fbf into php-tmdb:2.0 Mar 9, 2016
@rjkip rjkip deleted the maintenance/support-symfony-3 branch March 9, 2016 19:16
@wtfzdotnet
Copy link
Member

Thanks @rjkip, I'll get around to some updates to the lib hopefully this weekend, I'll push a new release for this now.

@rjkip
Copy link
Contributor Author

rjkip commented Mar 9, 2016

Quick response. Awesome!

@rjkip
Copy link
Contributor Author

rjkip commented Mar 9, 2016

Ah, I see the README still mentions PHP7 CI failures are allowed...

@wtfzdotnet
Copy link
Member

Got that covered in 30c1dfd, no worries :) thanks again! If you happen to come across something let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants