Skip to content

Set Retry-After to be one second by default in case of retries#158

Merged
yukoff merged 1 commit intophp-tmdb:2.0from
yukoff:hotfix/2.0/retry-after
Sep 9, 2017
Merged

Set Retry-After to be one second by default in case of retries#158
yukoff merged 1 commit intophp-tmdb:2.0from
yukoff:hotfix/2.0/retry-after

Conversation

@yukoff
Copy link
Copy Markdown
Contributor

@yukoff yukoff commented Sep 9, 2017

This is a follow-up to #155 - retry after 1 second by default in case of retry and 429 response header has Retry-After=0

There were cases, when client subsequently recieved 429 responses with
retry-after=0, eg.

* retries: 0, sleep: 1
* retries: 1, sleep: 0
* retries: 2, sleep: 0

On the next try you'll get error:
> Your request count (44) is over the allowed limit of 40.
@yukoff yukoff changed the title Retry after 1 second by default Set Retry-After to be one second by default in case of retries Sep 9, 2017
@yukoff yukoff merged commit 0d7f416 into php-tmdb:2.0 Sep 9, 2017
@yukoff yukoff deleted the hotfix/2.0/retry-after branch September 9, 2017 12:38
@yukoff yukoff added this to the v2.0.19 milestone Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant