Update setAllowedTypes in Client to use new signature#81
Merged
wtfzdotnet merged 1 commit intophp-tmdb:2.0from Jun 21, 2015
Merged
Update setAllowedTypes in Client to use new signature#81wtfzdotnet merged 1 commit intophp-tmdb:2.0from
wtfzdotnet merged 1 commit intophp-tmdb:2.0from
Conversation
Member
|
I've made this change before and if I recall correctly it didn't work with the minimal dependency versions as it is, could you verify this? ( composer has a flag to install the least versions possible ) |
Contributor
Author
|
You're right, the setAllowedTypes method was first changed in version 2.6, so this change doesn't work for lower versions |
Member
|
I'll leave this pull request open as this change will be made at a later date, pushing this through right now might burn some people's camp down :). Thanks for the effort! |
Member
|
@actioussan any way you could modify this PR to support both versions? I've given it some thought myself and would probably be best moving these two cases into separate classes? |
wtfzdotnet
added a commit
that referenced
this pull request
Jun 21, 2015
Update setAllowedTypes in Client to use new signature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptionsResolver::setAllowedTypes method with an array of options is deprecated since version 2.6 and will be removed in 3.0. Updated to use the new signature with a single option instead.