Skip to content

Allow passing options when importing or exporting a catalogue #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Allow passing options when importing or exporting a catalogue #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The change log describes what is "Added", "Removed", "Changed" or "Fixed" betwee

Drop support og php < 7.2
Add strict I/O type hinting
Allow passing options when exporting / importing a catalogue

## 1.0.0

Expand Down
4 changes: 2 additions & 2 deletions src/TransferableStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ interface TransferableStorage
/**
* Get messages from the storage into the $catalogue.
*/
public function export(MessageCatalogueInterface $catalogue): void;
public function export(MessageCatalogueInterface $catalogue, array $options = []): void;

/**
* Populate the storage with all the messages in $catalogue. This action
* should be considered as a "force merge". Existing messages in the storage
* will be overwritten but no message will be removed.
*/
public function import(MessageCatalogueInterface $catalogue): void;
public function import(MessageCatalogueInterface $catalogue, array $options = []): void;
}