Improve chain storage #38
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
odolbeau
force-pushed
the
improve-chain-storage
branch
from
8263fde to
fcf93b4
Compare
Nyholm
pushed a commit
to Nyholm/common
that referenced
this pull request
Mar 26, 2021
…on-phpstan Add PHPStan Github Action
|
Hey @odolbeau ! Any plans to finish this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayStorage. TBH it's probably useless (I dont have any use case in mind) and it's only here to be used in tests. I can move it into thetestsfolder if you think it makes sense.directionoption for theexportmethod of theChainStorage(theArrayStoragehave been introduced to test this behavior correctly without using Mock objects).