Feature Request: Better translation extraction

[prolic]

When looking for extractions, the extractor should check if a TranslatorInterface is injected either in constructor or a setter method and check what values are translated with it. This way a lot more translations can be extracted, without implementing TranslationSourceLocationContainer everywhere.

[Nyholm]

Yes, You are correct. Could you paste some code here that contains translations that are not extracted?

[prolic]

Well, something like this:

<?php

namespace My\Pdf;

use Symfony\Component\Translation\TranslatorInterface;

class PdfGenerator
{
    private $translator;

    public function __construct(TranslatorInterface $translator)
    {
        $this->translator = $translator;
    }

    /**
     * @return string
     */
    public function getPdfFilename(string $locale)
    {
        return $this->translator->trans('my.pdf', [], 'generic', $locale);
    }

    // some more code
}

[Nyholm]

(I've done some research). Currently we check for all $xx->trans() calls. The code you provided do work. We extract 'my.pdf'. See #30.

Could it be that we never try to extract from that file?

[prolic]

/cc @toooni Am 08.02.2017 21:05 schrieb "Tobias Nyholm" <notifications@github.com>:

…

(I've done some research). Currently we check for all $xx->trans() calls. The code you provided do work. We extract 'my.pdf'. See #30 <#30>. Could it be that we never try to extract from that file? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYEvGDYTfFQdX7F7rJyCilddVpQaz8Nks5rab2CgaJpZM4L00i5> .