Skip to content

[Bug] Add unit test to demonstrate incorrect child traversal behaviour #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 1 commit into from
Aug 12, 2017
Merged

[Bug] Add unit test to demonstrate incorrect child traversal behaviour #40

Nyholm merged 1 commit into from
Aug 12, 2017
+31 −3

Conversation

@samvdb
Copy link
Contributor

@samvdb samvdb commented Jun 15, 2017

See ticket #39

@Nyholm Nyholm self-requested a review June 15, 2017 14:28
@samvdb
Copy link
Contributor Author

samvdb commented Jun 15, 2017

If you have any suggestions for cleaning up BasePHPVisitor i would be glad to hear them.
I think giving support for multiple visitors is not a bad idea. Typehinting with array and changing the variable to $visitors would be nice.

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2017

Typehinting with array and changing the variable to $visitors would be nice.

I agree. Please do that.

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2017

Thank you Sam, Can you add your fix to the PR as well?

@Nyholm Nyholm merged commit a28f4be into php-translation:master Aug 12, 2017
@Nyholm
Copy link
Member

Nyholm commented Aug 12, 2017

Thank you. This was merged in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samvdb @Nyholm