Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Jan 3, 2018

This will fix #71

Ping @noofaq could you confirm?

Copy link
Contributor

@noofaq noofaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked your changes in my project and it seems to work better - I don't need to annotate "@ignore" 'label' keys in controller - thank you for that.

Small suggestions:

  1. maybe better is to check if SF MajorVersion == 2 to use "display value" by default and any other to use "display keys" as I don't expect Symfony team to switch back in the imaginable future
  2. I see that code for ensuring Form visitors are really in *Type context is duplicated in few visitor classes; as PHP>5.5 is targeted I would suggest to use it in a trait or to have abstract BaseTypeVisitor to reduce code duplication
  3. composer.json contains branch alias "1.2-dev" what creates conflicts when used with php-translation/symfony-bundle so I had to workaround that in my own composer.json using alias "dev-master as 1.3-dev"

Nonetheless, thank you for quick fixes 👍

@Nyholm
Copy link
Member Author

Nyholm commented Jan 6, 2018

Awesome. Thank you for the review. Ive done the changes you suggested.

@Nyholm Nyholm merged commit 06557d4 into master Jan 6, 2018
@Nyholm Nyholm deleted the issue-71 branch April 10, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with 'label' key in an array (outside of the Symfony Form context) [SF4]

3 participants