Skip to content

Scrutnizer fixes #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nyholm merged 1 commit into from
Aug 20, 2017
Merged

Scrutnizer fixes #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Translator/FallbackTranslator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ final class FallbackTranslator implements TranslatorInterface, TranslatorBagInte
/**
* @param string $defaultLocale
* @param TranslatorInterface $symfonyTranslator
* @param Translator $translatorService
* @param Translator $externalTranslator
*/
public function __construct($defaultLocale, TranslatorInterface $symfonyTranslator, Translator $externalTranslator)
{
Expand All @@ -55,7 +55,7 @@ public function __construct($defaultLocale, TranslatorInterface $symfonyTranslat
public function trans($id, array $parameters = [], $domain = null, $locale = null)
{
$id = (string) $id;
if (!$domain) {
if (empty($domain)) {
$domain = 'messages';
}

Expand All @@ -81,7 +81,7 @@ public function trans($id, array $parameters = [], $domain = null, $locale = nul
public function transChoice($id, $number, array $parameters = [], $domain = null, $locale = null)
{
$id = (string) $id;
if (!$domain) {
if (empty($domain)) {
$domain = 'messages';
}

Expand Down