Skip to content

Removing empty messages in the total count in webui, gives a better progress #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 2 commits into from
Dec 31, 2017
Merged

Removing empty messages in the total count in webui, gives a better progress #170

Nyholm merged 2 commits into from
Dec 31, 2017

Conversation

@lsv
Copy link
Contributor

@lsv lsv commented Dec 31, 2017

By removing empty messages in the progress counter, so it gives a more realistic overview of the progress counter in the webui

@Nyholm Nyholm self-requested a review December 31, 2017 12:08
Nyholm
Nyholm approved these changes Dec 31, 2017
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@Nyholm Nyholm merged commit 7d840ca into php-translation:master Dec 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lsv @Nyholm