Feature/webui overview #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsv
commented
Dec 31, 2017
lsv
commented
- Sorting message files, so they are similar over all languages
- Moved message counter from controller to twig, due to it affected the total count
- Some minor UI update
Member
|
You are on fire today =) Thanks! Does this also fix #148? |
Contributor
Author
Contributor
Author
|
And thats its why I added the (5 / 15) to the total, I couldnt figure out why it showed the total counter at 33% on all languages. Maybe the twig template could be cleaned up a bit |
Nyholm
approved these changes
Dec 31, 2017
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
I really appreciate your work!
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.