Feature/command obsolete #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsv
commented
Dec 31, 2017
lsv
commented
- Setting the php_translation.storage.default to public, due to its required by the obsolete command
- Updated obsolete command, so you will get better overview of what has been removed if you add -v
- Dont ask for anything if there are 0 obsolete messages
- Dont add progressbar if -q is added
Nyholm
requested changes
Dec 31, 2017
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thanks! I just had some minor comments
| $container->setAlias('php_translation.storage', new Alias('php_translation.storage.'.$first, true)); | ||
| if ('default' !== $first) { | ||
| $container->setAlias('php_translation.storage.default', 'php_translation.storage.'.$first); | ||
| $container->setAlias('php_translation.storage.default', new Alias('php_translation.storage.'.$first, true)); |
Member
There was a problem hiding this comment.
I do not mind. But we should remember to make it private before 1.0. We should register commands and controllers as proper services.
Command/DeleteObsoleteCommand.php
Outdated
| if ($progress) { | ||
| $progress->finish(); | ||
| } | ||
| exit(0); |
Member
There was a problem hiding this comment.
We should use return instead. This will not run command.terminate or other listeners
Command/DeleteObsoleteCommand.php
Outdated
| return; | ||
| } | ||
| $messageCount = count($messages); | ||
| if ($messageCount > 0) { |
Member
There was a problem hiding this comment.
Could we make this a bit prettier by doing:
if ($messageCount === 0) {
$output->writeln('No messages are obsolete');
return;
}
Member
|
Could you have a look at the changes and I'll be happy to merge. |
Nyholm
approved these changes
Feb 4, 2018
Member
|
I've made the changes. Thank you for creating this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.