Skip to content

Fixed Edit in place twig extension activator #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nyholm merged 2 commits into from
Apr 10, 2018
Merged

Fixed Edit in place twig extension activator #200

Nyholm merged 2 commits into from
Apr 10, 2018

Conversation

@DpVic
Copy link
Contributor

@DpVic DpVic commented Feb 17, 2018 •
edited by Nyholm
Loading

This will fix #181

@Nyholm Nyholm self-requested a review February 17, 2018 18:17
@Nyholm
Copy link
Member

Nyholm commented Apr 10, 2018

Awesome. Thank you for this fix and review.

I've added a minor commit do fix the code style and to remove the call to setActivator defined in Yaml.

@Nyholm Nyholm merged commit b98a193 into php-translation:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvanlaak rvanlaak rvanlaak approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Edit in place] Trans twig extension not using the configured activator

3 participants

@DpVic @Nyholm @rvanlaak