Remove useless array wrapping #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already check that it's an array in the configuration definition. This wrapping is useless and prevent proper options retrieving.
Contributor
Author
|
The build fail looks unrelated. |
Nyholm
approved these changes
Apr 10, 2018
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
You are very much correct. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already check that it's an array in the configuration definition.
This wraps the option array in another array, so the argument passed in the storage is "double wrapped" and cannot be properly used.
https://github.com/php-translation/symfony-storage/blob/e4446fe5243f5380df865d763564b28498b209ef/src/FileStorage.php#L60-L79