Fix the FileDumper::setBackup() method deprecation notice #236
Conversation
Also adds a compiler pass to assure the service definition remains unchanged on older Symfony versions
| { | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| if (Kernel::MAJOR_VERSION <= 3) { |
There was a problem hiding this comment.
Actually, consider doing failure first 🤔
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
I really like this. Thank you.
If you like to add a test that would be perfect.
Great work!
|
Hmmm, I'm kind of stuck writing a test for this 🤔. Because I'm unable to mock or overwrite the If you have any tips on this situation I'd love to hear. Otherwise I'm OK with merging |
|
Thank you for working on this. I wound not care with the sf major version. Let travis handle that. But Im not sure how I would write the tests... Maybe to check if the sf major version is less than 4, then make sure Thank you |
2 participants
Heya 👋
This PR should fix the deprecation notices for https://github.com/symfony/translation/blob/4.1/Dumper/FileDumper.php#L52
If you have any additions or changes I'd love to know.